OUT-2810, OUT-2814 | Template cards rearrange on hover #1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rrojan
requested changes
Dec 17, 2025
arpandhakal
force-pushed
the
OUT-2807
branch
from
5f77f7a to
3aa6735
Compare
…gn fixes - Sorted templates on templates board by createdAt. The rearrangement was caused because of updating redux store on hover. - Removed extra line at the top of tempalte detail page.
arpandhakal
force-pushed
the
OUT-2810
branch
from
4e83784 to
016d1db
Compare
…of having separate ones, memoized templats list
…of having separate ones, memoized templats list
rrojan
approved these changes
Dec 18, 2025
rrojan
reviewed
Dec 18, 2025
Collaborator
rrojan
left a comment
rrojan
left a comment
There was a problem hiding this comment.
To nitpick a bit, we shouldn't be making individual util files with individual function names. Instead we should scope util functions to a domain.
E.g. sortByDescendingOrder would belong in a file like tasks.ts
- added manual timestamps for subtasks while creating them from a template with respect to parent templates createdAt. - this process maintains that the subtasks are created parallely and in order which gives us both performance and ordering. - found another issue where subtasks creation from templates causes race condition on realtime, causing update events to fire before create events for subtasks, causing duplicate data. Fixed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing Criteria