generated from pagevamp/copilot-custom-app-starter-kit
-
Notifications
You must be signed in to change notification settings - Fork 1
feature/visual-improvements #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arpandhakal
wants to merge
43
commits into
main
Choose a base branch
from
feature/visual-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modified tasktemplates modal to support new fields subTaskTemplates, parentId with proper relations. - added a mechanism (API) to create subTaskTemplates for a template with proper validation. - Modified retrieve template and list templates request's response to include parentId and subTaskTemplates. - Also added support for getting subTaskTemplates in response for public facing APIs.
…oute
- deleted previous functionality of opening a template modal to edit template from template card.
- create a new route '/manage-templates/{id}' for viewing/editing template details
- replicated task details page for template details viewing/editing functionality
- created api to fetch subtasktemplates and implemented in template details page
- added propper api integrations for updating template details like title/description/workflowstates for parent and sub templates.
- managed realtime templates to reflect realtime changes on template details page
…e if the template is deleted in real time
…s with subtemplates
- Added a layout of subtasks indicator card on task creation form with clear all button. - added a functionality of clear all button to trigger disableSubtaskTemplates creation on task create api. - captured disabledSubtaskTemplates from search params on task create controller.
…tails page - added OneTemplateDataFetcher HOC in template details page to invalidate the cache. - prevented overriding the templates state if there are already some elements in the global templates state.
- Manage templates button on template options hidden when user is from notification center. - added template fetcher on tasks details page so that user can access templates dropdown on notification-center-view
…gn fixes - Sorted templates on templates board by createdAt. The rearrangement was caused because of updating redux store on hover. - Removed extra line at the top of tempalte detail page.
…of having separate ones, memoized templats list
…of having separate ones, memoized templats list
- added manual timestamps for subtasks while creating them from a template with respect to parent templates createdAt. - this process maintains that the subtasks are created parallely and in order which gives us both performance and ordering. - found another issue where subtasks creation from templates causes race condition on realtime, causing update events to fire before create events for subtasks, causing duplicate data. Fixed this.
- showing all subtasks on CRM view (the ones that are out of scope for the selected client) is something less feasible. Instead of that, created a mechanism where created subtasks with assigneeId and viewers same as the parent task for CRM view.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- create a new tab design using Tabs and Tab component from mui. - replaced buttons group with the tabs. - designed a new dropdown to replace filter by user types in mobile devices.
- changed colors of list view headers. The colors are conditional to the workflowstate type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes