Skip to content

Fix for Redis spawning new clients for each topic/queue #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

sardaukar
Copy link

this also includes a RSpec syntax update, I can't stand deprecation warnings :)

OK, so this fixes #20, but the behavior is not covered in tests. I'm not too well-versed in TDD, and would appreciate guidance in getting it done.

Thanks for the push to do this myself, the code is really clean and the change was real quick!

@sardaukar
Copy link
Author

btw, couldn't get Kestrel to run locally, so didn't touch those tests

@sardaukar
Copy link
Author

Hmm, not sure why the build failed - it passes locally for me on 2.1.5, with Redis 2.8.19

@sardaukar
Copy link
Author

Oh, I see - I wasn't using Bundler, so I have newer versions of RSpec and such... do you want to update the dependencies?

@copiousfreetime
Copy link
Owner

I'm doing some dependency updates right now to accomodate your pull request, Looks good so far.

@copiousfreetime copiousfreetime mentioned this pull request Feb 18, 2015
@copiousfreetime
Copy link
Owner

You can ignore the travis-ci items, that's because the maildir gem now says it requires ruby 2.0 or higher and jruby has 1.8 and 1.9 modes. I've merged this pull request with #22 (basically lots of project maintenance cleanup). Check out the redis-refactor branch and make sure it satisfies your needs. If so I'll close this one and merge in #22 and push a new gem.

@copiousfreetime
Copy link
Owner

Oh, and add yourself to CONTRIBUTING.md. A commit on this pull request will do, I'll cherrypick it over.

@copiousfreetime
Copy link
Owner

@sardaukar just making sure the redis-refactor branch works for you, I'm going to close this today and push a new qup release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce 1 connection to redis for each Session
2 participants