Some cleanups and fix incorrect evar map passing in aac_reflexivity #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`retype` dates from when we had old-API tactics, now unused. Use enter_one instead of enter to ensure we don't do nonsense when there are multiple goals (will anomaly if called with multiple goals in focus).
IDK how to make the dune based opam file run these
The code used to get the new goal to print but at some point was changed to print the old goal. Since nobody noticed this means this debug print is probably useless.
SkySkimmer
commented
Mar 1, 2024
This change is not expected to fix bugs but usually at the start of a Goal.enter we get the evar map with Goal.sigma not by using tclEVARMAP.
|
A lot of this stuff is over my head, but CI seems to work out. However, CI does not include the tests, since they would need to be added into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #135