Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add definition and result about regexp derivatives #73

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

palmskog
Copy link
Member

Derivation is in my view a basic operation on regular expressions and should be included in the library. Here is a port of the basic definitions and results from regexp-Brzozowski. To avoid the (cons-based) residual definition from language.v being shadowed, I rename the cat-based residual definition in dfa.v to residual_cat.

@chdoc
Copy link
Member

chdoc commented Jul 22, 2024

The naming collision is indeed unfortunate. However, I don't think that cat is the right is the right disambiguation here. If I understand correctly, the two definitions differ along two axes: one is whether they take the residual with respect to a character or a word, the other is that residual applies to decidable languages only.

@palmskog
Copy link
Member Author

@chdoc sure, there are two different differences. But what do you suggest instead of residual_cat then? I'd be fine with residual_lang (as opposed to dlang) or residual_lang_cat.

@chdoc
Copy link
Member

chdoc commented Jul 22, 2024

@chdoc sure, there are two different differences. But what do you suggest instead of residual_cat then? I'd be fine with residual_lang (as opposed to dlang) or residual_lang_cat.

I don't think there's any really great option, but I would prefer residual_lang over residual_cat.

@palmskog
Copy link
Member Author

@chdoc renaming done - so OK to merge now?

The CI issues are due to some issues with the Nix Toolbox, I disabled the failing configuration here, but CI will only stop failing when this PR is merged.

@palmskog palmskog merged commit 8b6b8a3 into master Jul 22, 2024
21 of 23 checks passed
@palmskog palmskog deleted the re-deriv branch July 22, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants