Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix messages in contiunous mode #1001

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix messages in contiunous mode #1001

merged 2 commits into from
Jan 22, 2025

Conversation

rtetley
Copy link
Collaborator

@rtetley rtetley commented Jan 21, 2025

This makes it so that queries and such are also stepped through when doing an interpret to position. This also fixes them in continuous mode.
Closes #997
Closes #951

This makes it so that queries and such are also stepped through when doing
an interpret to position. This also fixes them in continuous mode.
@rtetley rtetley requested a review from gares January 21, 2025 08:41
@rtetley
Copy link
Collaborator Author

rtetley commented Jan 21, 2025

@gares is this what you had in mind from #997 ?

@gares
Copy link
Member

gares commented Jan 21, 2025

Yes

1 similar comment
@gares
Copy link
Member

gares commented Jan 21, 2025

Yes

@rtetley
Copy link
Collaborator Author

rtetley commented Jan 21, 2025

I'll fix the test suite and merge

@rtetley rtetley merged commit 084a980 into main Jan 22, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in continuous mode Inconsistent step highlighting
2 participants