Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDS-1576] resource type filter & AP3 region - PR again #156

Merged
merged 8 commits into from
Oct 11, 2024
Merged

[CDS-1576] resource type filter & AP3 region - PR again #156

merged 8 commits into from
Oct 11, 2024

Conversation

ryantanjunming
Copy link
Contributor

Description

  • Added resource type filtering
  • Added AP3 region

How Has This Been Tested?

Checklist:

  • I have updated the versions in the changed module in the template index.js and package.json files.
  • I have updated the relevant component changelog(s)
  • This change does not affect module (e.g. it's readme file change)

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

guyrenny and others added 7 commits October 11, 2024 18:43
@guyrenny @ryantanjunming
change layer code to use nodejs18 code instead of 16 when running on …
4219206 
…lambdas with nodejs20 (#154)

Signed-off-by: Ryan Tan <ryantanjunming@gmail.com>
@ryantanjunming
resource type filter & AP3 region
fcc8da3 
Signed-off-by: Ryan Tan <ryantanjunming@gmail.com>
@ryantanjunming
IAM conditioning
abd989d 
Signed-off-by: Ryan Tan <ryantanjunming@gmail.com>
@ryantanjunming
sam validate fix, changed key
4709abd 
Signed-off-by: Ryan Tan <ryantanjunming@gmail.com>
@ryantanjunming
fix invocation comment
6342b5b
@ryantanjunming
boolean correction
faf8017
@ryantanjunming
set boolean as strings instead
b4d6661
@ryantanjunming
Revert "change layer code to use nodejs18 code instead of 16 when run…
0af2395 
…ning on lambdas with nodejs20 (#154)"

This reverts commit 4219206.
@ryantanjunming ryantanjunming merged commit fdb9eed into master Oct 11, 2024
12 of 13 checks passed
@ryantanjunming ryantanjunming deleted the fix/cds-1576-again branch October 11, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalSumislawski RafalSumislawski RafalSumislawski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryantanjunming @CLAassistant @RafalSumislawski @guyrenny