Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to define custom headers to log requests #18

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Added option to define custom headers to log requests #18

merged 1 commit into from
Apr 1, 2024

Conversation

tomerf
Copy link
Contributor

@tomerf tomerf commented Mar 12, 2024

This PR adds an option to override the headers in the send logs request.
It is useful when using a proxy that requires authentication for example.

@royfur royfur requested a review from daidokoro March 12, 2024 11:02
daidokoro
daidokoro approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@daidokoro daidokoro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomerf

LGTM

@tomerf, note that this repo requires all commits to be signed.

@tomerf tomerf force-pushed the custom_headers branch 2 times, most recently from cd4fa4a to f988624 Compare April 1, 2024 20:45
@tomerf
Copy link
Contributor Author

tomerf commented Apr 1, 2024

Weird, I already configured this laptop to sign commits 🤷‍♂️
Now it's signed

@royfur royfur merged commit 72e4690 into coralogix:master Apr 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daidokoro daidokoro daidokoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomerf @daidokoro @royfur