Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions for ecr integration #153

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Fix permissions for ecr integration #153

merged 2 commits into from
Mar 21, 2024

Conversation

guyrenny
Copy link
Contributor

Description

The default permission for the lambda had deny ecr:DescribeImageScanFindings permission, which cause the integration in case you use Ecr to fail

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the relevant example in the examples directory for the module.
  • I have updated the relevant test file for the module.
  • This change does not affect module (e.g. it's readme file change)

@guyrenny guyrenny requested a review from a team as a code owner March 21, 2024 14:22
Copy link
Contributor

@juan-coralogix juan-coralogix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guyrenny guyrenny merged commit 899e22f into master Mar 21, 2024
5 checks passed
@guyrenny guyrenny deleted the ecr-bug-fix branch March 21, 2024 14:28
Copy link

🎉 This PR is included in version 1.0.93 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants