Add DLQ support, and new variable for cloudwatch integration #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 1.0.98 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
- Update the github action to avoid the node.js 16 issue
- Create a new variable log_group_prefix to avoid the limitation of the number of log groups
- Add support for DLQ
Fixes #How Has This Been Tested?
Tests the log_group_prefix manually, and check that the lambda has permission according to the variable.
Ran the DLQ option and saw that in case of an error in the lambda, i got the log file in the S3 bucket.
Ran E2E test for all of the integrations to make sure that there is no other issues.
Checklist: