Feature/cds 1390 firehose

[ryantanjunming]

Description

• Added custom naming for resources
• Added ability to data reference global resources (s3 & iam)
  🛑 Breaking changes 🛑
  Update variables: private_key renamed to api_key with type string instead of any.

How Has This Been Tested?

Locally

Checklist:

• I have updated the relevant example in the examples directory for the module.
• I have updated the relevant test file for the module.
• This change does not affect module (e.g. it's readme file change)

[guyrenny]

LGTM

[guyrenny]

Need to also update the variables.tf file in the examples folder.

[github-actions]

🎉 This PR is included in version 1.0.105 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[gregops312]

I have to ask why this change was released and you didn't release a major version change, since after all swapping arguments is a breaking change to your consumers. I am specifically referring to moving from private_key to api_keyin firehose-metrics

And the documentation for the module has no note of the change, its only visible in the commit, and never made it in the release notes.

[ryantanjunming]

Hi @gregops312, many apologies I should have written it in the PR, it was documented in the ChangeLog.md: https://github.com/coralogix/terraform-coralogix-aws/blob/feature/cds-1390-firehose/CHANGELOG.md#v10105

There will also be another change to the coralogix_region soon to follow https://coralogix.com/docs/user-guides/account-management/account-settings/coralogix-domain/

[gregops312]

Hi @gregops312, many apologies I should have written it in the PR, it was documented in the ChangeLog.md: https://github.com/coralogix/terraform-coralogix-aws/blob/feature/cds-1390-firehose/CHANGELOG.md#v10105

There will also be another change to the coralogix_region soon to follow https://coralogix.com/docs/user-guides/account-management/account-settings/coralogix-domain/

Thanks for that, I stupidly didn't actually look at the ChangeLog.md that is definitely on me. Thanks I will put a note in our usage so we are ready for when that changes.