-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cds 1390 firehose #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to also update the variables.tf file in the examples folder.
# Conflicts: # CHANGELOG.md
🎉 This PR is included in version 1.0.105 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
I have to ask why this change was released and you didn't release a major version change, since after all swapping arguments is a breaking change to your consumers. I am specifically referring to moving from And the documentation for the module has no note of the change, its only visible in the commit, and never made it in the release notes. |
Hi @gregops312, many apologies I should have written it in the PR, it was documented in the ChangeLog.md: https://github.com/coralogix/terraform-coralogix-aws/blob/feature/cds-1390-firehose/CHANGELOG.md#v10105 There will also be another change to the |
Thanks for that, I stupidly didn't actually look at the |
Description
🛑 Breaking changes 🛑
Update variables:
private_key
renamed toapi_key
with typestring
instead ofany
.How Has This Been Tested?
Locally
Checklist: