Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked Accounts Metrics #180

Closed
wants to merge 4 commits into from
Closed

Conversation

jakeskyaws
Copy link
Contributor

Summary of Changes

  1. New Variable for Linked Accounts Metrics:

    • A new variable include_linked_accounts_metrics is added. This variable allows the inclusion of metrics from linked source accounts when creating a metric stream in a monitoring account. It defaults to false.
  2. Additional Parameters for Metric Streams:

    • Support for include_linked_accounts_metrics is added to aws_cloudwatch_metric_stream, enabling users to specify whether to include metrics from linked accounts.
  3. Enhancements to Existing Variables:

    • Existing variables such as include_metric_stream_namespaces, include_metric_stream_filter, and additional_metric_statistics_enable are retained and clarified. The additional_metric_statistics_enable boolean variable controls the inclusion of additional statistics in the streamed metrics.
    • Descriptions for metric filters and statistics guide users to AWS documentation for viewing available namespaces, metric names, and statistics.
  4. Changes to Terraform Files:

    • Additions in main.tf and variables.tf include variables and configurations for linked account metrics, along with modifications to aws_cloudwatch_metric_stream.
  5. README Update:

    • Documentation is updated to reflect the new option for linked account metrics and enhancements in guiding users through metric stream setup.

@jakeskyaws jakeskyaws requested a review from a team as a code owner September 25, 2024 14:19
@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ guyrenny
✅ iancoralogix
❌ ryantanjunming
❌ jakeskyaws


jakeskyaws seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jakeskyaws
Copy link
Contributor Author

I can see You have agreed to the CLA for coralogix/terraform-coralogix-aws yet your workflow remains pending

@daidokoro
Copy link
Contributor

Thanks for the PR @jakeskyaws

There seems to be an issue with your commits preventing them from being properly recognized as signed.

Please insure that *all commits associated with this PR have been signed. This commit has not been signed.

Also, insure to add the email address used for this commit to your account.

jakeskyaws and others added 4 commits October 8, 2024 11:58
* add ap3 region to integration, and add output to msk-data-stream integration

* add entry to changelog
… Url & AP3 region changes (#175)

* main changes added

* wrong variable

* AP3 readme

* update variables description

* domain naming and fixes

* changelog and readme

* more readme

* example files

* fix issue with tests

* change private_key to api_key in firehose-logs test

* fix readme and descriptions

* update changelog

---------

Co-authored-by: guyrenny <guy.renny@coralogix.com>
@jakeskyaws jakeskyaws closed this by deleting the head repository Oct 9, 2024
@jakeskyaws
Copy link
Contributor Author

jakeskyaws commented Oct 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants