Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cds-1580 fix Otel ECS-EC2 configuration #182

Merged
merged 4 commits into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# Changelog

## v2.0.1
### 🧰 Bug fixes 🧰
- Fixed ecs-ec2 module, adjusted cdot image command to `--config env:OTEL_CONFIG`
- Removed latest flag from ecs-ec2 module example.
- Removed deprecated logging exporter from ecs-ec2 module otel configs.

### 💡 Enhancements
- Added pprof extension to default ecs-ec2 otel configurations.


## v2.0.0
### 🛑 Breaking changes 🛑
- Remove deprecated modules: cloudwatch-logs, S3 and kinesis
Expand Down
2 changes: 1 addition & 1 deletion examples/ecs-ec2/ecs-ec2.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ provider "aws" {
module "otel_ecs_ec2_coralogix" {
source = "coralogix/aws/coralogix//modules/ecs-ec2"
ecs_cluster_name = "test-lab-cluster"
image_version = "latest"
image_version = "v0.3.1"
memory = 256
coralogix_region = "EU1"
custom_domain = null
Expand Down
1 change: 1 addition & 0 deletions modules/ecs-ec2/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ resource "aws_ecs_task_definition" "coralogix_otel_agent" {
value : local.otel_config
}
],
command: ["--config", "env:OTEL_CONFIG"],
healthCheck : {
command : ["CMD-SHELL", "nc -vz localhost 13133 || exit 1"]
startPeriod : 30
Expand Down
4 changes: 3 additions & 1 deletion modules/ecs-ec2/otel_config.tftpl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,17 @@ exporters:
- "aws.ecs.docker.name"
- "docker.name"
timeout: 30s
logging:
debug:
verbosity: detailed

extensions:
health_check:
pprof:

service:
extensions:
- health_check
- pprof
telemetry:
logs:
level: warn
Expand Down
5 changes: 4 additions & 1 deletion modules/ecs-ec2/otel_config_metrics.tftpl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ processors:
override: false

exporters:
logging:
debug:
verbosity: detailed
coralogix:
domain: "$CORALOGIX_DOMAIN"
private_key: "$PRIVATE_KEY"
Expand All @@ -101,10 +102,12 @@ exporters:

extensions:
health_check:
pprof:

service:
extensions:
- health_check
- pprof
telemetry:
logs:
level: warn
Expand Down
Loading