Add methodOfRedress to DSA tenant settings
#4395
Merged
+178
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabeaty
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Looking good overall! Just two things:
- If
emailorurlis selected as the method of redress, should there also be an input shown to add the appropriate email/url to be shown in this case? - Do we also need to update the
defaultDSAConfigurationinsrc/core/server/models/settings/settings.tsto includemethodOfRedress: GQLDSA_METHOD_OF_REDRESS.NONE?
| URL = "URL", | ||
| } | ||
|
|
||
| export const parseVal = (v: any, name: string) => { |
There was a problem hiding this comment.
Do we need this parseVal and format? Seems like it works fine without them?
There was a problem hiding this comment.
it wasn't working for me without them, but I can try again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
methodOfRedressto the tenant DSA settings.These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
Adds
methodOfRedressto theDSAConfigurationtype and it's corresponding settings inputs.Does this PR introduce any new environment variables or feature flags?
No
If any indexes were added, were they added to
INDEXES.md?No new indices.
How do I test this PR?
Admin > Config > General > Digital services actSelect your method of redressNoneWhere any tests migrated to React Testing Library?
No
How do we deploy this PR?
Merge into DSA epic branch and release with rest of epic.