Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSA final copy updates #4399

Merged
merged 13 commits into from
Nov 20, 2023
Merged

Conversation

nick-funk
Copy link
Contributor

@nick-funk nick-funk commented Nov 16, 2023

What does this PR do?

  • Final copy text for titles and descriptions on notifications
  • Some new icons for notifications (rejected comment icon)
  • Updated styles for the embedded comment on some notifications, updates the text and makes the toggle-able comment component more re-usable

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

No new indices.

How do I test this PR?

  • create some comments
  • DSA report and decide on the report for some of the comments
  • regularly reject some comments in the mod queues
  • check the notifications for both the reporters and the commenters to see new copy and styles in notifications area

Where any tests migrated to React Testing Library?

No

How do we deploy this PR?

  • Merge into DSA epic branch

Copy link
Contributor

@kabeaty kabeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@nick-funk nick-funk changed the base branch from feat/DSA-config-method-of-redress to feat/dsa-launch-pad November 20, 2023 16:10
@nick-funk nick-funk merged commit 4092c15 into feat/dsa-launch-pad Nov 20, 2023
@nick-funk nick-funk deleted the fix/dsa-notifications-final-copy branch November 20, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants