Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-2934]: More DSA polish #4402

Merged
merged 20 commits into from
Nov 20, 2023
Merged

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Nov 17, 2023

What does this PR do?

These changes make a number of design UI and copy updates related to DSA feature QA.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

  • Check out the updated copy on the report form
  • The confirmation screen is updated after you submit a report (test with both successful submissions and a submission that errors)
  • Go into user history drawer for a commenter that has had a comment rejected for illegal content. See that there is a marker for Illegal content next to that comment in the Rejected tab
  • Add additional comments to a DSA report in the report form and see the updated/streamlined flow
  • In the admin, on the single DSA Report page, click Decision button to open the make a decision modal and see the updated styles/functionality there
  • There is now a cursor pointer shown when hovering over the Reports table in the admin
  • Clicking on the Comments tab from the report form page (and permalink page) now goes back to all comments
  • If you add a really long text input to the law broken input, it will be truncated when shown in the Reports table
  • When clicking Report and seeing the report illegal content link in the report form for a comment, the link copy is updated and an icon added
  • on page load, if the report form isn't in view, it is now scrolled down to

Where any tests migrated to React Testing Library?

How do we deploy this PR?

Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tests are whining, but I'm sure that's a quick tweak here and there and this can go in!

Comment on lines +185 to +194
(c) =>
(c.revision && c.revision.actionCounts.illegal.total > 0 && (
<Marker key={keyCounter++} color="reported">
<Localized id="moderate-marker-illegal">
<span>Illegal content</span>
</Localized>{" "}
<MarkerCount>{c.revision.actionCounts.illegal.total}</MarkerCount>
</Marker>
)) ||
null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh neat, there's an illegal content marker now

@kabeaty kabeaty merged commit f03ac12 into feat/dsa-launch-pad Nov 20, 2023
2 checks passed
@kabeaty kabeaty deleted the feat/CORL-2934-more-polish branch November 20, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants