-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORL-2934]: More DSA polish #4402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; remove copy link
nick-funk
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tests are whining, but I'm sure that's a quick tweak here and there and this can go in!
Comment on lines
+185
to
+194
(c) => | ||
(c.revision && c.revision.actionCounts.illegal.total > 0 && ( | ||
<Marker key={keyCounter++} color="reported"> | ||
<Localized id="moderate-marker-illegal"> | ||
<span>Illegal content</span> | ||
</Localized>{" "} | ||
<MarkerCount>{c.revision.actionCounts.illegal.total}</MarkerCount> | ||
</Marker> | ||
)) || | ||
null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh neat, there's an illegal content marker now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes make a number of design UI and copy updates related to DSA feature QA.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
none
Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md
?n/a
How do I test this PR?
Illegal content
next to that comment in theRejected
tabDecision
button to open the make a decision modal and see the updated styles/functionality thereComments
tab from the report form page (and permalink page) now goes back to all commentslaw broken
input, it will be truncated when shown in the Reports tableReport
and seeing the report illegal content link in the report form for a comment, the link copy is updated and an icon addedWhere any tests migrated to React Testing Library?
How do we deploy this PR?