[CORL-296]7 view conversation rejection reasons #4405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
position modal
…conversation-rejection-reasons
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
kabeaty
reviewed
Nov 20, 2023
| @@ -131,7 +133,8 @@ async function moderateComments( | |||
| filter: FilterQuery<Comment>, | |||
| targetStatus: GQLCOMMENT_STATUS, | |||
| now: Date, | |||
| isArchived = false | |||
| isArchived = false, | |||
| rejectionReason?: Moderate["rejectionReason"] | |||
There was a problem hiding this comment.
Should the type here be GQLRejectionReason?
4 tasks
kabeaty
deleted the
feat/CORL-2967-view-conversation-rejection-reasons
branch
nick-funk
reviewed
Nov 20, 2023
| isArchived, | ||
| { | ||
| code: GQLREJECTION_REASON_CODE.OTHER, | ||
| detailedExplanation: "User account deleted", |
There was a problem hiding this comment.
We can translate this using the following:
import { I18n, translate } from "coral-server/services/i18n";
...
const text = "User account deleted";
const key = "common-userDeletion-userAccountDeleted";
const args = {};
const bundle = this.i18n.getBundle(tenant.locale);
const result = translate(bundle, text, key, args);
Then the translations for this can be specified in common.ftl under server/src/core/server/lcoales/en-US.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug in which the moderation reasons modal doesn't close after seelcting a reason when in the user drawer. It also updates the user deletion flow to include comment rejection reasons when rejecting the deleted users comments.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
None.
Does this PR introduce any new environment variables or feature flags?
No.
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
Navigate to a user drawer for any usera as an user with mod privileges, with DSA enabled. Reject a comment from the drawer. Observe that a reason is requried, and when one is supplied, the Moderation Reason modal closes.
Find a user with comments with no replies. As that user, request that your account be deleted. In the database, set the scheduled deletion time to something soon. Observe that the account is successfully deteleted, and the comments with no replies are rejected, and the resulting CommentModerationActions specify a reason.
Where any tests migrated to React Testing Library?
No