Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSA no notifications placeholder text #4408

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

nick-funk
Copy link
Contributor

What does this PR do?

  • Show placeholder text when user has no notifications
  • Make method of redress email/url a link

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

No new indices

How do I test this PR?

  • Turn on DSA mode in Admin > Configure > General > DSA
  • Select the Email or URL option for method of redress and provide a value
  • Make a new user
  • Check their notifications
  • See that they have a placeholder when they have no notifications
  • Create a comment
  • Reject it
  • Check notifications
  • See that the notification appeared for the rejection
  • See that the method of redress shows with a link to the email/url option you filled out in the config earlier

Where any tests migrated to React Testing Library?

No

How do we deploy this PR?

  • Merge to DSA epic branch

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit b6bdc40
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/655b902da61bc800088e86be

@nick-funk nick-funk changed the base branch from develop to feat/dsa-launch-pad November 20, 2023 16:58
Copy link
Contributor

@kabeaty kabeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approving! Left one small question.

@nick-funk nick-funk merged commit 4ce4d1f into feat/dsa-launch-pad Nov 20, 2023
1 check passed
@nick-funk nick-funk deleted the fix/dsa-no-notifications-placeholder branch November 20, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants