Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update README #164

Merged
merged 2 commits into from
Aug 2, 2024
Merged

chore: Update README #164

merged 2 commits into from
Aug 2, 2024

Conversation

fardin01
Copy link
Contributor

This commit updates the README to include the findings in #137, because it is useful to have this information directly in the README rather than having to search for it.

README.md Outdated Show resolved Hide resolved
example/403.html Outdated Show resolved Hide resolved
This commit updates the README to include the findings in corazawaf#137, because it is useful to have this information directly in the README rather than having to search for it.
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The next obvious step will be (in a followup PR) to add this example as part of the github action build process, so we can test everything works properly 😄

@fardin01
Copy link
Contributor Author

fardin01 commented Aug 2, 2024

LGTM. The next obvious step will be (in a followup PR) to add this example as part of the github action build process, so we can test everything works properly 😄

Great.

Do you mean adding it to e2e tests?

@fzipi
Copy link
Member

fzipi commented Aug 2, 2024

🤔 It was more about checking that the example files are sane and won't break anything if used.
I was thinking on a simple GHA that starts a caddy server with the example files and we test the response using curl or similar to see if it contains the host, etc. But if that is about e2e, then could be.

@M4tteoP
Copy link
Member

M4tteoP commented Aug 2, 2024

Note: tests are failing because of #165, this branch needs to be rebased once that PR is merged

Copy link

sonarcloud bot commented Aug 2, 2024

@fzipi fzipi merged commit e5437b0 into corazawaf:main Aug 2, 2024
5 checks passed
@fardin01 fardin01 deleted the doc branch August 2, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants