feat: uses memoization to decrease memory consumption. #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Aug 10, 2023
Given that this wasm-extension does not have hot reload (instead we delegate that responsibility to the proxy) we could enable the memoize_builders by default as there is no risk to memory leak as every time the cache is being purgued.
jcchavezs
force-pushed
the
uses_memoization
branch
from
187cdb8
to
fb9a440
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables memoization of builders for
regexandaho-corasickdictionaries to reduce memory consumption in deployments that launch several coraza instances (e.g. several authorities). For more context check corazawaf/coraza-caddy#76