feat(e2e): swaps e2e with the official Coraza ones, updates Go to 1.20 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M4tteoP
commented
Aug 24, 2023
| @@ -12,12 +12,12 @@ on: | |||
| workflow_dispatch: | |||
|
|
|||
| env: | |||
| GO_VERSION: 1.19 | |||
| GO_VERSION: '1.20' | |||
There was a problem hiding this comment.
Note: Due to the peculiarities of YAML parsing, it is recommended to wrap the version in single quotation marks:
go-version: '1.20'The recommendation is based on the YAML parser's behavior, which interprets non-wrapped values as numbers and, in the case of version 1.20, trims it down to 1.2, which may not be very obvious.
M4tteoP
changed the title
jcchavezs
reviewed
Sep 6, 2023
anuraaga
approved these changes
Sep 6, 2023
jcchavezs
approved these changes
Sep 6, 2023
jcchavezs
reviewed
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
envoy:v1.27to workflows and as the default image for docker-compose files