fix: stackoverflow in ReadFrom (#925)

* fix stackoverflow in ReadFrom - failing test * fix stackoverflow
corazawaf · Nov 27, 2023 · 4c7f918 · 4c7f918
1 parent a95ea5f
commit 4c7f918
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/http/interceptor.go b/http/interceptor.go
@@ -109,7 +109,7 @@ func (i *rwInterceptor) Header() http.Header {
 }
 
 func (i *rwInterceptor) ReadFrom(r io.Reader) (n int64, err error) {
-	return io.Copy(i, r)
+	return io.Copy(struct{ io.Writer }{i}, r)
 }
 
 func (i *rwInterceptor) Flush() {

diff --git a/http/interceptor_test.go b/http/interceptor_test.go
@@ -214,6 +214,11 @@ func TestReadFrom(t *testing.T) {
 		t.Errorf("unexpected error: %v", err)
 	}
 
+	_, err = rw.(io.ReaderFrom).ReadFrom(struct{ io.Reader }{bytes.NewBuffer([]byte("hello world"))})
+	if err != nil {
+		t.Errorf("unexpected error: %v", err)
+	}
+
 	err = responseProcessor(tx, req)
 	if err != nil {
 		t.Errorf("unexpected error: %v", err)