Skip to content

Commit

Permalink
Fix timeout to make CI work
Browse files Browse the repository at this point in the history
  • Loading branch information
M4tteoP committed Aug 9, 2024
1 parent 7bd957d commit 8af20c9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions testing/coreruleset/albedo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ type reflectionSpec struct {
}

func handleReflect(t testing.TB, w http.ResponseWriter, r *http.Request) {
t.Helper()
log.Println("Received reflection request")

body, err := io.ReadAll(r.Body)
Expand Down
4 changes: 2 additions & 2 deletions testing/coreruleset/coreruleset_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,8 @@ SecRule REQUEST_HEADERS:X-CRS-Test "@rx ^.*$" \
// Tests would not just be ignored, but new expectations would be set for the specific platform
// E.g. see https://github.com/coreruleset/coreruleset/blob/main/tests/regression/nginx-overrides.yaml
res, err := runner.Run(cfg, tests, runner.RunnerConfig{
ShowTime: false,
ConnectTimeout: 10 * time.Second, // WIP: Defaults to 3s but looks to be not enough
ShowTime: false,
ReadTimeout: 3 * time.Second, // Defaults to 1s but looks to be not enough in the CI
}, output.NewOutput("quiet", os.Stdout))
if err != nil {
t.Fatal(err)
Expand Down

0 comments on commit 8af20c9

Please sign in to comment.