chore: ports interceptor correction #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
+ Coverage 82.72% 83.91% +1.19%
==========================================
Files 162 166 +4
Lines 9080 7891 -1189
==========================================
- Hits 7511 6622 -889
+ Misses 1319 1019 -300
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jcchavezs
approved these changes
Sep 27, 2024
|
@9mlcy7 Sorry, can you translate your thoughts into English? |
|
@9mlcy7 how is this a problem? if no interception we aim to return the write return values as they are isn't? |
|
@jcchavezs You're right; the issue occurred because I made some custom modifications to the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports from caddy to the reference implementation some @jcchavezs's findings. See: corazawaf/coraza-caddy#107