perf: reduces transformArg allocation without multimatch #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathetake
reviewed
Nov 8, 2024
| @@ -242,8 +242,17 @@ func (r *Rule) doEvaluate(logger debuglog.Logger, phase types.RulePhase, tx *Tra | |||
| } | |||
| vLog.Debug().Msg("Expanding arguments for rule") | |||
|
|
|||
| args := make([]string, 1) | |||
There was a problem hiding this comment.
it seems worth removing this allocation as well I guess?
There was a problem hiding this comment.
Yes, I have some a WIP with further refactoring, but so far I've not been able to achieve more performance / fewer allocations, even removing this line. I would merge this first to get some optimizations in and iterate over for further ones
jcchavezs
approved these changes
Nov 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1198 +/- ##
==========================================
+ Coverage 81.63% 81.64% +0.01%
==========================================
Files 168 168
Lines 9630 9637 +7
==========================================
+ Hits 7861 7868 +7
Misses 1519 1519
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids allocations when calling
transformArg()withoutMultimatch. This has been done by specializing thetransformArginto:transformArg(..): which returns just an individual string with all the transformations computed. It permits to avoid allocating slices with just one element.transformMultiMatchArg: which returns a slice of strings that include all the unique intermediate transformationsBefore:
After: