docs: nits and avoids mentioning not existing resources #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M4tteoP
changed the title
M4tteoP
commented
Nov 7, 2024
| @@ -774,9 +774,6 @@ func directiveSecAuditLogRelevantStatus(options *DirectiveOptions) error { | |||
| // Syntax: SecAuditLogParts [PARTLETTERS] | |||
| // Default: ABCFHZ | |||
| // --- | |||
| // The format of the audit log format is documented in detail in the Audit Log Data | |||
| // Format Documentation. | |||
There was a problem hiding this comment.
Is Audit Log Data Format Documentation somewhere? If so, we should point it here. I can't find it and the same line looks to be copy pasted from ModSec doc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
==========================================
+ Coverage 82.72% 83.46% +0.74%
==========================================
Files 162 166 +4
Lines 9080 9611 +531
==========================================
+ Hits 7511 8022 +511
- Misses 1319 1338 +19
- Partials 250 251 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jcchavezs
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.