Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make check and make install on MacOS #40

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Fix make check and make install on MacOS #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
012af09
Fix make check and make install on MacOS
brentos Sep 19, 2024
46e452b
Add macos-latest to CI
brentos Sep 24, 2024
5787737
Install autoconf automake libtool for macOS runners
brentos Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/make-install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
matrix:
go-version: [1.18.x, 1.19.x]
os: [ubuntu-latest]
os: [ubuntu-latest, macos-latest]
runs-on: ${{ matrix.os }}
steps:
- name: Install Go
Expand All @@ -20,6 +20,10 @@ jobs:
with:
lfs: true
fetch-depth: 0 #for better blame info
- name: Install macOS dependencies
if: runner.os == 'macOS'
run: |
brew install autoconf automake libtool
- name: Setup
run: |
./build.sh
Expand Down
2 changes: 1 addition & 1 deletion Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ docs:
check_PROGRAMS = tests/simple_get

if OSX
AM_LDFLAGS = -framework CoreFoundation
AM_LDFLAGS = -framework CoreFoundation -framework Security
endif

if LINUX
Expand Down
2 changes: 1 addition & 1 deletion tests/simple_get.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

#include "coraza/coraza.h"

void logcb(void *log, const void *data)
void logcb(const void *data)
{
printf("%s\n", (const char *)data);
}
Expand Down
Loading