Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax some validations for trusted inputs #703

Merged

Conversation

jtrobles-cdd
Copy link
Member

  • dte: Relax some DteXmlData validations for trusted inputs
  • rtc: Add option to trust the input when parsing AEC XML documents

Ref: https://app.shortcut.com/cordada/story/9837

@jtrobles-cdd jtrobles-cdd added the enhancement New feature or request label Sep 26, 2024
@jtrobles-cdd jtrobles-cdd self-assigned this Sep 26, 2024
@jtrobles-cdd jtrobles-cdd requested a review from a team as a code owner September 26, 2024 17:36
Copy link

sonarcloud bot commented Sep 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
24.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jtrobles-cdd jtrobles-cdd merged commit c07cb11 into develop Sep 26, 2024
17 of 18 checks passed
@jtrobles-cdd jtrobles-cdd deleted the feature/sii-dte-skip-validations-when-input-is-trusted branch September 26, 2024 17:40
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (d257a60) to head (36c374b).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #703      +/-   ##
===========================================
+ Coverage    87.53%   87.59%   +0.05%     
===========================================
  Files           38       38              
  Lines         3113     3127      +14     
  Branches       382      385       +3     
===========================================
+ Hits          2725     2739      +14     
  Misses         246      246              
  Partials       142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yrios-cdd yrios-cdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants