Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #67

Merged
merged 22 commits into from
Nov 16, 2023
Merged

Updates #67

merged 22 commits into from
Nov 16, 2023

Conversation

dbrgn
Copy link
Member

@dbrgn dbrgn commented Nov 7, 2023

...it has been a while 😄

@dbrgn dbrgn added the chore label Nov 7, 2023
@dbrgn dbrgn self-assigned this Nov 7, 2023
@dbrgn dbrgn force-pushed the updates branch 3 times, most recently from 2c43530 to 413c83a Compare November 7, 2023 23:17
@rnestler
Copy link
Member

rnestler commented Nov 8, 2023

...it has been a while 😄

Dependabot maybe?

@rnestler
Copy link
Member

rnestler commented Nov 8, 2023

CI fails after the last upgrade.

@threema-danilo
Copy link

CI fails after the last upgrade.

Yeah, the upgrade isn't done yet. I plan to continue the upgrade up to Django 4.2 LTS.

Regarding the failure, I'm a bit confused why it happens, the same check works locally. But I gave up debugging yesterday.

@rnestler
Copy link
Member

rnestler commented Nov 9, 2023

Yeah, the upgrade isn't done yet. I plan to continue the upgrade up to Django 4.2 LTS.

If it is workable on the state of 8a93762 we can also just merge it with this state as an intermediate step.

@threema-danilo
Copy link

(Oops, I commented with the wrong account 😄)

If it is workable on the state of 8a93762 we can also just merge it with this state as an intermediate step.

I'd prefer to only test the changes once, and not twice 🙂 I'll finish the updates next week. (I did some tests locally, plus the unit tests, but there could be issues with deployment setup etc that must be tested after releasing.)

pytest: 6 → 7
pytest-cov: 2.7 → 4.1
pytest-django: 4.4 → 4.6
pytest-dotenv: 0.3 → 0.5
model-mommy: 1.6 → 2.0
frezegun: 0.3 → 1.2
@dbrgn dbrgn marked this pull request as draft November 13, 2023 22:06
@dbrgn dbrgn marked this pull request as ready for review November 16, 2023 20:16
@dbrgn
Copy link
Member Author

dbrgn commented Nov 16, 2023

@rnestler ready to merge now. I assume this is OK to merge without review 🙂

The deployment should happen automatically within a few minutes IIRC. Once deployed, I'll give it a quick test.

@dbrgn dbrgn merged commit 35faaea into master Nov 16, 2023
3 checks passed
@dbrgn dbrgn deleted the updates branch November 16, 2023 20:27
@rnestler
Copy link
Member

The deployment should happen automatically within a few minutes IIRC. Once deployed, I'll give it a quick test.

The "Profile" menu item in the logged in menu doesn't do anything. But I'm not sure if it ever did 😉
screenshot-20231117-101148

@dbrgn
Copy link
Member Author

dbrgn commented Nov 17, 2023

Doesn't look like it ever did 😂

<li><a href="#">Profile</a></li>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants