Allow admins (and only admins) to change owner

[david-a-wheeler]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (e6abd6d) to head (8a6fc43).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2169   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files          55       55           
  Lines        2128     2130    +2     
=======================================
+ Hits         2087     2089    +2     
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TonyLHansen]

I'm not a ruby-nista, so I'm probably missing it. Shouldn't the old owner get added to the list of editors?

[david-a-wheeler]

You could do that as well, but I don't want to automatically do that. Sometimes people leave projects entirely. The two fields are right next to each other, so an admin could easily do it if they chose (cut/paste owner id to the additional editors, then write the new owner id).

[TonyLHansen]

That's fair. Perhaps add a reminder note to the html page "If the current owner should retain editor rights, remember to add them to the editor list as well."

[david-a-wheeler]

Ok, I'll add some reminder text. Note: Currently I'm intentionally NOT internationalizing this text, since it's ONLY for admins, and our long-suffering translators have enough to do. It would be easy to internationalize later.

I'll tweak the automated tests further to verify the options only shown when it's supposed to be shown.

[TonyLHansen]

thanks