-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openshift/v4.16: Stabilize 4.16.0 spec and add openshift 4.17-experimental spec #535
Conversation
2a14d87
to
0c9a587
Compare
8e74e3b
to
6f7f189
Compare
https://github.com/coreos/butane/blob/main/internal/doc/butane.yaml#L352 > Those need to be updated to list 4.16.0 now as part of the GRUB removal change. |
Found two more "typos" but there are other missing changes (GRUB password support should be there). One way to make this easier when creating the new experimental version is to copy the files from before we stabilized the 4.16-exp version and then updating 16 to 17, as everything else will stay the same. |
2827001
to
74511d2
Compare
I updated it. Can you take a look? Thanks! |
I re-did to avoid mistakes while doing the 4.17.0_exp. I think now is closer to the ideal. Can you take another look and see what is missing? Thanks! |
1dfc357
to
82ca2f1
Compare
I think this looks good. One change needed for the release notes and then I'll do a final check/review. |
57bfae7
to
8edce08
Compare
I changed docs/upgrading-openshift.md. Any other docs updated or are we good to go? Thanks! |
I think everything looks okay now. Feel free to review it again and tell me if there is anything I could improve! |
Stabilize on ignition 3.4, fcos 1.5 and base 0.5 specs
Support is still missing in the MCO. See: https://issues.redhat.com/browse/MCO-630
8edce08
to
0212c04
Compare
Thanks, this looks complete. I did a minor re-split of the commits but changed nothing to what you did. So LGTM. |
openshift/v4.16: Stabilize 4.16.0 spec
Stabilize on ignition 3.4, fcos 1.5 and base 0.5 specs
openshift/v4.16: Remove GRUB password support
Support is still missing in the MCO.
See: https://issues.redhat.com/browse/MCO-630
openshift/v4_17_exp: Add 4.17.0-experimental spec
Fixes: #533