test: verify FCOS runs on TDX_CAPABLE instances in GCP
#3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
HuijingHei
force-pushed
the
gcp-cvm-tdx
branch
from
017bdda to
62a085b
Compare
dustymabe
reviewed
Feb 12, 2025
dustymabe
reviewed
Feb 12, 2025
dustymabe
reviewed
Feb 12, 2025
dustymabe
reviewed
Feb 12, 2025
HuijingHei
force-pushed
the
gcp-cvm-tdx
branch
from
62a085b to
28d8786
Compare
See coreos/fedora-coreos-tracker#1814 Use type `c3-standard-4` with only 1 disk that uses the NVMe interface, as Intel TDX `c3-standard-4-lssd` is not supported yet. (Refer to https://cloud.google.com/confidential-computing/confidential-vm/docs/supported-configurations#limitations)
HuijingHei
force-pushed
the
gcp-cvm-tdx
branch
from
28d8786 to
d063918
Compare
HuijingHei
added a commit
to HuijingHei/fedora-coreos-pipeline
that referenced
this pull request
Feb 12, 2025
Update config to run SNP test and add Intel TDX test. See coreos/fedora-coreos-config#3356
dustymabe
approved these changes
Feb 13, 2025
Comment on lines
+141
to
+146
| # Verify the instance is Confidential VM type that matches expected | ||
| assert_confidential_type_match() { | ||
| local cvm_type=$(systemd-detect-virt --cvm) | ||
| local expected=$1 | ||
| [ "${cvm_type}" == "${expected}" ] | ||
| } |
There was a problem hiding this comment.
I assume you left this here because it would be useful outside of GCP confidential compute tests?
There was a problem hiding this comment.
Yes, it might be also useful if running Confidential VM on other platform, for example Azure.
jbtrystram
added a commit
to jbtrystram/fedora-coreos-pipeline
that referenced
this pull request
Feb 14, 2025
In coreos/fedora-coreos-config#3356 the test was updated and split in two tests, changing the names.
jbtrystram
pushed a commit
to HuijingHei/fedora-coreos-pipeline
that referenced
this pull request
Feb 14, 2025
Update config to run SNP test and add Intel TDX test. See coreos/fedora-coreos-config#3356
jbtrystram
pushed a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
Feb 14, 2025
Update config to run SNP test and add Intel TDX test. See coreos/fedora-coreos-config#3356
HuijingHei
added a commit
to HuijingHei/fedora-coreos-pipeline
that referenced
this pull request
Feb 14, 2025
Update config to run SNP test and add Intel TDX test. See: - test script coreos/fedora-coreos-config#3356 - tracker issue coreos/fedora-coreos-tracker#1814
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See coreos/fedora-coreos-tracker#1814
Use type
c3-standard-4with only 1 disk that uses the NVMe interface, as Intel TDXc3-standard-4-lssdis not supported yet. (Refer to https://cloud.google.com/confidential-computing/confidential-vm/docs/supported-configurations#limitations)