Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand development docs and rationale #1686

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Expand development docs and rationale #1686

merged 3 commits into from
Aug 11, 2023

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Aug 3, 2023

Rendered version here.

@bgilbert
Copy link
Contributor Author

bgilbert commented Aug 3, 2023

I think this one can skip release notes.

@bgilbert
Copy link
Contributor Author

bgilbert commented Aug 4, 2023

cc @dustymabe @prestist

@travier travier added the skip-notes This PR does not need release notes label Aug 11, 2023
@travier
Copy link
Member

travier commented Aug 11, 2023

Looks great. Thanks!

@travier
Copy link
Member

travier commented Aug 11, 2023

Merging as this is a doc only change.

@travier travier merged commit b439abf into coreos:main Aug 11, 2023
9 of 10 checks passed
dustymabe
dustymabe reviewed Aug 11, 2023
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I only had one suggestion.

docs/development.md Show resolved Hide resolved
@bgilbert bgilbert deleted the devdocs branch August 11, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe left review comments

@travier travier travier approved these changes

Assignees
No one assigned
Labels
skip-notes This PR does not need release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgilbert @travier @dustymabe