Schema additions and improvements for v2.0 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `follow_redirect` to enable redirect tracking using multiple test stages - add `encoded_data` to allow complex request data to be passed more consistently - rename `expect_id` and `no_expect_id` to plural form and make them accept a list of ints; especially `no_expect_ids` can be helpful when writing tests for exclusion rules
- add `StageIds` to platform overrides to target overrides to specific stages - remove `ExpectFailure` in favor of the existing `Output.ExpectError`; there's no longer a reason for configuration to simply fail as we have full control over expectations - remove `FileName`, which can be derived and shouldn't be a hard-coded value - add `RuleId` to top-level test structure to replace test title, file name, with rule ID + test ID - add `IdString()` function to print the matchable test ID (<rule ID>-<test ID>) - removed the additional `StageData` struct
fzipi
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by coreruleset/go-ftw#209