fix(deps): revert koanf to v1.5 #211
Conversation
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
|
I don't understand the issue. All they need to do is the same that I've done, which is to use |
|
The problem is this: I learned that dependencies might also pull koanf. But they pull v1. Because of that, there is a namespace collision upstream. So, to move forward, we might need to change our code and include v2 but use it in a different namespace, like |
|
The error: |
|
The dependency graph: |
|
From what I can see, they only pull in koanf because of go-ftw, and that only in the |
|
The namespace thing I'm not familiar with. I'll have to look into that. |
|
It is just the name used when importing. If you do: then you'll have a collision because both are imported as "koanf". Tipically you use it like: So there is a way to make both versions work. The first one will be "koanf" and the second "koanfv2". |
|
I see. We can certainly do that. I'm trying to think how this will play out, because at some point I would want to drop |
|
Do you still want to first revert to |
|
Let's to the namespace change instead. I'll push the changes here. |
|
Moved to #212 instead. If that doesn't work, we can push this one. |
While the update works for go-ftw, koanf v2 is not used in other dependent libraries and breaks when used.
E.g. corazawaf/coraza#908