feat: implement quantitative tests using raw files #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
theseion
requested changes
Jul 28, 2025
There was a problem hiding this comment.
How about making leipzig and raw subcommands of corpus. They can inherit all the stuff from the corpus command (which wouldn't have any functionality itself) and implementation would be very concise for each of them (and new types).
There was a problem hiding this comment.
So this would be then go-ftw quantitative corpus raw .... for example?
Comment on lines
+37
to
+41
| s.tempDir, err = os.MkdirTemp("", "raw_corpus_test") | ||
| s.Require().NoError(err) | ||
|
|
||
| // Create a test file with sample payloads | ||
| s.tempFile = filepath.Join(s.tempDir, "test_corpus.txt") |
There was a problem hiding this comment.
Suggested change
| s.tempDir, err = os.MkdirTemp("", "raw_corpus_test") | |
| s.Require().NoError(err) | |
| // Create a test file with sample payloads | |
| s.tempFile = filepath.Join(s.tempDir, "test_corpus.txt") | |
| // Create a test file with sample payloads | |
| s.tempFile = filepath.Join(s.T().TempDir(), "test_corpus.txt") |
| suite.Suite | ||
| corpus corpus.Corpus | ||
| tempFile string | ||
| tempDir string |
There was a problem hiding this comment.
Suggested change
| tempDir string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
refs