Fix Panic when Name can't be determined and check the filesystem to determine directory #952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some bugs reported by @petobens, thanks so much for the reports!
The first is a panic when the last bit of the path as
..
, because it usedPath::file_name
and paniced on..
, which is documented to returnNone
.https://doc.rust-lang.org/std/path/struct.Path.html#method.file_name
Now we return a
None
as well, and when we need to render the filename we use the input string instead so we should see..
un-modified in that caseThe second fix is to better identify directories. Now instead of just checking for a trailing slash, we ask the file system as a fallback. This supports both local and absolute paths