Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freshli.io lead gen MVP #45

Merged
merged 42 commits into from
Jul 22, 2020
Merged

Freshli.io lead gen MVP #45

merged 42 commits into from
Jul 22, 2020

Conversation

mscottford
Copy link
Member

@mscottford mscottford commented Jul 5, 2020

Adds super simple start at a website for Freshli.io. On the "homepage" users can provide a URL to be scanned. Calculation work is handled by a background job worker, and results are stored in the database used by Freshli.io.

There is still a lot more to do, but this is a pretty good point to merge into main at this point.

@mscottford mscottford marked this pull request as ready for review July 21, 2020 07:17
@mscottford mscottford requested a review from nickiemc July 21, 2020 07:21
- Moves creation logic into controller
- Adds route for displaying the details for a specific request (this is where we can display the results when they are ready along with the status of the request)
Copy link
Contributor

@nickiemc nickiemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall! 💯 🏗️

I added some pretty minor comments. Additionally, can you also update the README so that it better reflects the updated project structure and setup and deployment instructions?

.github/workflows/dotnet-core.yml Show resolved Hide resolved
Dockerfile.web Outdated Show resolved Hide resolved
Dockerfile.worker Outdated Show resolved Hide resolved
Freshli.Web/Controllers/HomeController.cs Outdated Show resolved Hide resolved
Freshli.Web/Views/Home/Privacy.cshtml Show resolved Hide resolved
Freshli.Web/Views/Shared/Error.cshtml Show resolved Hide resolved
Freshli.Web/Views/Shared/_Layout.cshtml Show resolved Hide resolved
Freshli.Web/appsettings.Development.json Show resolved Hide resolved
Freshli.Web/wwwroot/js/site.js Show resolved Hide resolved
@mscottford
Copy link
Member Author

@nickiemc I think that I have addressed all of your comments. Please take another peek and let me know.

@nickiemc
Copy link
Contributor

I made some minor tweaks to the README. Everything else looks good!

@nickiemc nickiemc merged commit 172a3b3 into main Jul 22, 2020
@nickiemc nickiemc deleted the web branch July 22, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants