Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update edition, add counter keyword #34

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

chris-ha458
Copy link
Contributor

Small fixes.

i feel that they are benign but default but explicit would be okay as well.

all values are default except `lto=true` (default is false) and `codegen-units=1` (default is 16)
many people search for this package by searching for counter
Copy link
Owner

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed response; I've been on vacation.

After removing the profile section and fixing the spacing, this looks plausible.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
address comments
@chris-ha458
Copy link
Contributor Author

addressed both in d4f5ed9 !

@coriolinus coriolinus changed the title Small fixes update edition, add counter keyword Aug 28, 2023
@coriolinus coriolinus merged commit 9e217dc into coriolinus:master Aug 28, 2023
1 check passed
@chris-ha458 chris-ha458 deleted the small_fixes branch August 28, 2023 11:38
ruancomelli referenced this pull request in ruancomelli/learning-rust Jul 1, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [counter](https://togithub.com/coriolinus/counter-rs) | dependencies |
minor | `0.5.7` -> `0.6.0` |

---

### Release Notes

<details>
<summary>coriolinus/counter-rs (counter)</summary>

###
[`v0.6.0`](https://togithub.com/coriolinus/counter-rs/releases/tag/v0.6.0)

[Compare
Source](https://togithub.com/coriolinus/counter-rs/compare/v0.5.7...v0.6.0)

#### What's Changed

- update edition, add `counter` keyword by
[@&#8203;chris-ha458](https://togithub.com/chris-ha458) in
[https://github.com/coriolinus/counter-rs/pull/34](https://togithub.com/coriolinus/counter-rs/pull/34)
- refactor tests and impls into distinct modules by
[@&#8203;chris-ha458](https://togithub.com/chris-ha458) in
[https://github.com/coriolinus/counter-rs/pull/36](https://togithub.com/coriolinus/counter-rs/pull/36)
- small doc formatting by
[@&#8203;chris-ha458](https://togithub.com/chris-ha458) in
[https://github.com/coriolinus/counter-rs/pull/38](https://togithub.com/coriolinus/counter-rs/pull/38)
- deprecate `init` method by
[@&#8203;coriolinus](https://togithub.com/coriolinus) in
[https://github.com/coriolinus/counter-rs/pull/41](https://togithub.com/coriolinus/counter-rs/pull/41)
- do not use deprecated `init` method by
[@&#8203;coriolinus](https://togithub.com/coriolinus) in
[https://github.com/coriolinus/counter-rs/pull/42](https://togithub.com/coriolinus/counter-rs/pull/42)
- With capacity by
[@&#8203;chris-ha458](https://togithub.com/chris-ha458) in
[https://github.com/coriolinus/counter-rs/pull/40](https://togithub.com/coriolinus/counter-rs/pull/40)
- Clippy fixes by
[@&#8203;chris-ha458](https://togithub.com/chris-ha458) in
[https://github.com/coriolinus/counter-rs/pull/43](https://togithub.com/coriolinus/counter-rs/pull/43)
- Implement Serialize and Deserialize by
[@&#8203;matthewmcintire-savantx](https://togithub.com/matthewmcintire-savantx)
in
[https://github.com/coriolinus/counter-rs/pull/46](https://togithub.com/coriolinus/counter-rs/pull/46)

#### New Contributors

- [@&#8203;chris-ha458](https://togithub.com/chris-ha458) made their
first contribution in
[https://github.com/coriolinus/counter-rs/pull/34](https://togithub.com/coriolinus/counter-rs/pull/34)
-
[@&#8203;matthewmcintire-savantx](https://togithub.com/matthewmcintire-savantx)
made their first contribution in
[https://github.com/coriolinus/counter-rs/pull/46](https://togithub.com/coriolinus/counter-rs/pull/46)

**Full Changelog**:
coriolinus/counter-rs@v0.5.7...v0.5.8

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ruancomelli/learning-rust).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZSJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants