Implement Serialize and Deserialize #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coriolinus
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Good idea in principle! The major change I'd like to see is making this feature optional and disabled by default, so that people don't bring in serde as a dependency unless they actually want it.
I'd also like to see a section of documentation in the README describing the features, the defaults, etc.
coriolinus
reviewed
Sep 28, 2023
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
coriolinus
previously approved these changes
Sep 29, 2023
coriolinus
approved these changes
Sep 29, 2023
ruancomelli
referenced
this pull request
in ruancomelli/learning-rust
Jul 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [counter](https://togithub.com/coriolinus/counter-rs) | dependencies | minor | `0.5.7` -> `0.6.0` | --- ### Release Notes <details> <summary>coriolinus/counter-rs (counter)</summary> ### [`v0.6.0`](https://togithub.com/coriolinus/counter-rs/releases/tag/v0.6.0) [Compare Source](https://togithub.com/coriolinus/counter-rs/compare/v0.5.7...v0.6.0) #### What's Changed - update edition, add `counter` keyword by [@​chris-ha458](https://togithub.com/chris-ha458) in [https://github.com/coriolinus/counter-rs/pull/34](https://togithub.com/coriolinus/counter-rs/pull/34) - refactor tests and impls into distinct modules by [@​chris-ha458](https://togithub.com/chris-ha458) in [https://github.com/coriolinus/counter-rs/pull/36](https://togithub.com/coriolinus/counter-rs/pull/36) - small doc formatting by [@​chris-ha458](https://togithub.com/chris-ha458) in [https://github.com/coriolinus/counter-rs/pull/38](https://togithub.com/coriolinus/counter-rs/pull/38) - deprecate `init` method by [@​coriolinus](https://togithub.com/coriolinus) in [https://github.com/coriolinus/counter-rs/pull/41](https://togithub.com/coriolinus/counter-rs/pull/41) - do not use deprecated `init` method by [@​coriolinus](https://togithub.com/coriolinus) in [https://github.com/coriolinus/counter-rs/pull/42](https://togithub.com/coriolinus/counter-rs/pull/42) - With capacity by [@​chris-ha458](https://togithub.com/chris-ha458) in [https://github.com/coriolinus/counter-rs/pull/40](https://togithub.com/coriolinus/counter-rs/pull/40) - Clippy fixes by [@​chris-ha458](https://togithub.com/chris-ha458) in [https://github.com/coriolinus/counter-rs/pull/43](https://togithub.com/coriolinus/counter-rs/pull/43) - Implement Serialize and Deserialize by [@​matthewmcintire-savantx](https://togithub.com/matthewmcintire-savantx) in [https://github.com/coriolinus/counter-rs/pull/46](https://togithub.com/coriolinus/counter-rs/pull/46) #### New Contributors - [@​chris-ha458](https://togithub.com/chris-ha458) made their first contribution in [https://github.com/coriolinus/counter-rs/pull/34](https://togithub.com/coriolinus/counter-rs/pull/34) - [@​matthewmcintire-savantx](https://togithub.com/matthewmcintire-savantx) made their first contribution in [https://github.com/coriolinus/counter-rs/pull/46](https://togithub.com/coriolinus/counter-rs/pull/46) **Full Changelog**: coriolinus/counter-rs@v0.5.7...v0.5.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ruancomelli/learning-rust). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for web assembly