Improve notifications frontend #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 88. |
pratyush1712
changed the title
Enochen
reviewed
Mar 8, 2023
|
|
||
| return ( | ||
| <Popup | ||
| trigger={ | ||
| <button className={styles.bell}> | ||
| <button id="popup" className={styles.bell}> |
There was a problem hiding this comment.
I've already commented on this, but we should not be hardcoding id's within components. Maybe we can fix this after we migrate to modern React (18) where you get the useId hook natively.
Enochen
previously approved these changes
Mar 10, 2023
SGupta101
reviewed
Mar 26, 2023
|
Your preview environment cornell-dti-carriage-web-pr-420 has been deployed. Preview environment endpoints are available at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Branching off of the previous popup aria tag fix pr, this pr improves the notifications design and implements view more functionality.
Note
This work is purely intuitive and is not based on any designs, so feel free to suggest any improvements or put it on hold until we have designs ready.
Test Plan
Home.-.Carriage.-.Brave.2023-03-08.01-40-58.mp4