Display employee photos in cards #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 17. |
CollinWoo
reviewed
Nov 15, 2023
| return true; | ||
| const employees: Record<string, DriverType | AdminType> = {}; | ||
| [...admins, ...drivers].forEach((employee) => { | ||
| employees[employee.id] = { ...employees[employee.id], ...employee }; |
There was a problem hiding this comment.
I think one potential concern with this array destructuring is that fields other than photolink could be overridden as well if they differ between the driver and the admin. I'm not sure how often this would occur though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows photos to be visible. The issue was that admin accounts supported photos but no admin account in the db actually has a photo. However the corresponding driver accounts do have photos.
This PR "combines" the two employee account objects so that you only need a
photoLinkin either your admin or driver account for it to display in your card.Note that this will use the driver
photoLinkif both are provided. In the future we should aim to restructure the DB so that this kind of ambiguity isn't possible.Test Plan
Notes
Note that this will use the driver
photoLinkif both are provided. In the future we should aim to restructure the DB so that this kind of ambiguity isn't possible.