Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add employee search bar #480

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Add employee search bar #480

merged 4 commits into from
Nov 21, 2023

Conversation

Enochen
Copy link
Contributor

@Enochen Enochen commented Nov 8, 2023

Summary

This adopts the search bar from the students page.

It searches firstName, lastName, email, phoneNumber, vehicle.name, and roles if applicable (sds-admin or redrunner-admin only)

Test Plan

empty

image

result exists ![image](https://github.com/cornell-dti/carriage-web/assets/3837473/3c71dd03-aa0e-4a06-b9ea-c385c68e28bc)
no result ![image](https://github.com/cornell-dti/carriage-web/assets/3837473/ac8d258d-2716-477a-bf2b-669b51d2530f)

@Enochen Enochen requested a review from a team as a code owner November 8, 2023 00:15
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 86.

Copy link
Member

@pratyush1712 pratyush1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look very good. I liked the usage of useMemo hook to optimize searching and using a common component in both employees and students page

@kevin-lin12
Copy link
Contributor

Looks great! I love how you kept the code style the same for the student search. Makes the code a lot easier to understand and read.

Copy link
Contributor

@SGupta101 SGupta101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Enoch! Tested on different browsers and works as expected.

@Enochen Enochen merged commit bde2483 into master Nov 21, 2023
6 checks passed
@Enochen Enochen deleted the enoch/employee-search branch November 21, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants