Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rides must be at least 5 minutes long #516

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

raissaji
Copy link
Contributor

@raissaji raissaji commented May 6, 2024

Summary

This pull request requires each ride to be at least 5 minutes long.

Test Plan

Screenshot 2024-05-05 at 6 13 03 PM

Notes

This PR does not require that each driver's rides are at least 5 minutes apart.

@raissaji raissaji requested a review from a team as a code owner May 6, 2024 00:49
@dti-github-bot
Copy link
Member

dti-github-bot commented May 6, 2024

[diff-counting] Significant lines: 25.

@selenaliu1
Copy link
Contributor

Hi Raissa! Overall this pull request looks good to me :) One thing I noticed is there is some repetition here of the following pattern: parseInt(time.substring(0, time.indexOf(':'))). This repeats here and for minDiff, so I think you could consider writing a helper function to abstract this for readability purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants