Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snapping when scrolling the schedule on homepage. #518

Closed
wants to merge 7 commits into from

Conversation

namanhboi
Copy link
Contributor

@namanhboi namanhboi commented May 6, 2024

Summary

Implemented snapping when scrolling on the schedule. The the rows are snapped on top and the columns are snapped to the end.

screen-capture.2.webm

The vertical scrolling works as expected, but there's still some weird behavior for horizontal scroll. The scroll sometimes get snapped to a portion in the middle of a cell instead of to the end. I will try to investigate the docs for scroll-snap-align more thoroughly in the future to see why.

screen-capture (3).webm
Some weird behavior with horizontal snapping

This pull request is the first step towards redesigning the schedule on the home page.

Test Plan

I tested the scrolling on different screen sizes and it doesn't work too well on smaller screens like the Iphone, so I might have to do a media queries in the future.

@namanhboi namanhboi requested a review from a team as a code owner May 6, 2024 02:20
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 16.

@Atikpui007
Copy link
Collaborator

closing because we can handle this in a better way. Will update the ticket to address this issue

@Atikpui007 Atikpui007 closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants