Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement achievements backend #185

Merged
merged 21 commits into from
Apr 23, 2024
Merged

Implement achievements backend #185

merged 21 commits into from
Apr 23, 2024

Conversation

jasmineee-li
Copy link
Contributor

Summary

This pull request implements the achievements backend for CornellGO.

  • implemented achievement DTO, service, gateway
  • partially implemented e2e integration tests for achievement

Remaining TODOs:

  • complete integration testing
  • complete tracking
  • test endpoints

@nit0107
Copy link
Contributor

nit0107 commented Apr 15, 2024

This looks like a good start! Make sure to finish the integration testing to ensure good coverage and pull from main/resolve merge conflicts so we can implement!

@dti-github-bot
Copy link
Member

dti-github-bot commented Apr 15, 2024

[diff-counting] Significant lines: 858.

Copy link
Collaborator

@neketka neketka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on achievements! Make sure to go over my comments and these all should be minor changes.

server/src/achievement/achievement.e2e-spec.ts Outdated Show resolved Hide resolved
server/src/achievement/achievement.e2e-spec.ts Outdated Show resolved Hide resolved
server/src/achievement/achievement.gateway.ts Outdated Show resolved Hide resolved
server/src/achievement/achievement.gateway.ts Outdated Show resolved Hide resolved
server/src/achievement/achievement.gateway.ts Show resolved Hide resolved
server/src/achievement/achievement.service.ts Show resolved Hide resolved
server/src/organization/organization.service.ts Outdated Show resolved Hide resolved
server/src/achievement/achievement.service.ts Outdated Show resolved Hide resolved
server/src/client/client.service.ts Outdated Show resolved Hide resolved
server/src/client/client.service.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@cgu2020 cgu2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately does not compile. Dbreset is failing. Pls fix :)

jasmineee-li and others added 8 commits April 18, 2024 11:25
-Modified prisma schema to link achievements to organizations
-Fixed bugs in achievement DTO, service, gateway
-Fixed logic in updateEventData, updateChallengeData, updateAchievementData
-Removed old code from faulty merge
Copy link
Collaborator

@neketka neketka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments

server/src/achievement/achievement.service.ts Outdated Show resolved Hide resolved
admin/src/all.dto.ts Outdated Show resolved Hide resolved
@neketka neketka merged commit ff6aaac into master Apr 23, 2024
12 checks passed
@neketka neketka deleted the jxl9/achievements-backend branch April 23, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants