-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement achievements backend #185
Conversation
This looks like a good start! Make sure to finish the integration testing to ensure good coverage and pull from main/resolve merge conflicts so we can implement! |
[diff-counting] Significant lines: 858. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start on achievements! Make sure to go over my comments and these all should be minor changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately does not compile. Dbreset is failing. Pls fix :)
-Modified prisma schema to link achievements to organizations -Fixed bugs in achievement DTO, service, gateway -Fixed logic in updateEventData, updateChallengeData, updateAchievementData -Removed old code from faulty merge
This reverts commit bc318b8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments
Summary
This pull request implements the achievements backend for CornellGO.
Remaining TODOs: