Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping registration when google account already exists #209

Merged
merged 31 commits into from
Apr 28, 2024

Conversation

neketka
Copy link
Collaborator

@neketka neketka commented Apr 25, 2024

Summary

This pull request allows skipping the registration process when a user has registered before.

  • Reorganize login code
  • Run dart fix --apply
  • Log into the main screen if initial login request succeeds
  • Add format all
  • Fix room leaking issue (again)
  • Realtime leaderboard

@dti-github-bot
Copy link
Member

dti-github-bot commented Apr 25, 2024

[diff-counting] Significant lines: 665.

@neketka neketka marked this pull request as ready for review April 28, 2024 04:42
Copy link
Contributor

@cathli66 cathli66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the formatall shortcut and changing the app icon! The disconnect logic all works as expected. For leaderboard updates, points update in real time but the username changes don't reflect until I restart the app. Can't check if Google login works but I trust you

game/lib/model/event_model.dart Outdated Show resolved Hide resolved
game/lib/main.dart Show resolved Hide resolved
Copy link
Contributor

@cathli66 cathli66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed my comments, thank you!

@cathli66 cathli66 merged commit 59e48d0 into master Apr 28, 2024
12 checks passed
@cathli66 cathli66 deleted the nikita/fix-google-login branch April 28, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants