Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to gameplay map + more #213

Merged
merged 12 commits into from
May 1, 2024
Merged

Updates to gameplay map + more #213

merged 12 commits into from
May 1, 2024

Conversation

cathli66
Copy link
Contributor

@cathli66 cathli66 commented Apr 28, 2024

Summary

This pull request implements some fixes to gameplay map and page. It also adds in the 3 new location types that PMs wanted when we discussed with dev leads about the dev social challenges.

  • User location icon now rotates from center and not bottom
  • Edited description and name text fields for gameplay page and completed challenge page
  • Completing the challenge now occurs upon pressing I've Arrived (before was Point Breakdown)
  • Removed Leave button after pressing I've Arrived to complete a challenge
  • Fixed hint radius initialization
  • Added 3 new location types (VET_SCHOOL, CENTRAL_CAMPUS, CORNELL_ATHLETICS)

Remaining TODOs:

  • User location icon resize and higher res
  • After “I’ve Arrived”, Nevermind and Use Hint button are too close
  • After you use all hints, hint button should not appear on “Nearly There” popup

Test Plan

  1. Start a challenge. Use two or three hints and try to keep track of how big the circle is, then leave challenge. Go back to the challenge, and check that the hint circle is the same size as how u left it. (The center of the circle may be different though)
  2. Check that the user location icon is around the right size (should be a bit smaller than the hint/recenter buttons)
  3. Upon completing, check that the challenge name appears in the Congratulations! dialog and that this is different from the challenge description on the top of the gameplay page.

Already tested on other devices during work session:

  • User location icon rotates around center

Breaking Changes

  • Database schema change (adding in 3 new location types)

@dti-github-bot
Copy link
Member

dti-github-bot commented Apr 28, 2024

[diff-counting] Significant lines: 294.

@cathli66 cathli66 marked this pull request as draft April 28, 2024 22:08
@cathli66 cathli66 marked this pull request as ready for review May 1, 2024 03:16
Copy link
Collaborator

@neketka neketka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed over slack lgtm

@cathli66 cathli66 merged commit d30293e into master May 1, 2024
12 checks passed
@cathli66 cathli66 deleted the cl893/gameplay-updates branch May 1, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants