-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Members/csv upload #485
Merged
Merged
Members/csv upload #485
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
908f182
file upload and json conversion
oscarwang20 fae006c
dependency
oscarwang20 d8b6143
member update
oscarwang20 d484106
removed dropzone, using input instead
oscarwang20 acfa304
file upload input
oscarwang20 256693e
error message for no file
oscarwang20 7d39127
fixed styling
oscarwang20 0cd43d9
removed unnecesary import
oscarwang20 150a7bc
error handling and current data keeping
oscarwang20 84fc30d
add new member empty fields
oscarwang20 586035f
currMember
oscarwang20 47968e4
ux changes and code duplication
oscarwang20 ad7d60a
error messages and styling
oscarwang20 e116396
removed RenderUploadStatus
oscarwang20 c62b791
text wrapping buttons
oscarwang20 2877b88
removed members[]
oscarwang20 9612e20
disable no implicit any rule
oscarwang20 4be50ac
back to old ways
oscarwang20 e55d898
upload status rework
oscarwang20 8895c30
role, subteam, email checks; truthy empty array
oscarwang20 5029ce3
more specific error messages
oscarwang20 d39b7ba
code repetition in error checking and subteam contained in formerSubt…
oscarwang20 031347a
formerSubteam check
oscarwang20 0672b09
removed console log
oscarwang20 079baed
former subteam existence check
oscarwang20 0224ed5
removed console logs
oscarwang20 28c8d85
refactored based on excel/sheets formatting
oscarwang20 08ba2d9
sample file download and small fixes
oscarwang20 2dc3d52
small changes
oscarwang20 8973c41
removed unnecessary role null check since already in error checker
oscarwang20 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
role && !ALL_ROLES.includes(role as Role)
, so that "missing role" cases don't fall into this category.