Add TEC to homepage #500
Closed
Add TEC to homepage #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 213. |
|
@patriciaahuang I think you branched off of add-name-to-readme when making this branch, so you have an extra commit from that other branch on this branch. Just a reminder for future reference. No matter, once you merge in your change for readme, just run git checkout main And it should disappear from the diff. |
|
Can you take a screenshot of the homepage and add it to the description, so that we can see how this looks? Makes it easier to review quickly/verify we're seeing the same thing. |
* add candidate decider helper text * prettier * remove name prop * remove unused input
|
lgtm! make sure to run prettier with |
* file upload and json conversion * dependency * member update * removed dropzone, using input instead * file upload input * error message for no file * fixed styling * removed unnecesary import * error handling and current data keeping * add new member empty fields * currMember * ux changes and code duplication * error messages and styling * removed RenderUploadStatus * text wrapping buttons * removed members[] * disable no implicit any rule * back to old ways * upload status rework * role, subteam, email checks; truthy empty array * more specific error messages * code repetition in error checking and subteam contained in formerSubteams * formerSubteam check * removed console log * former subteam existence check * removed console logs * refactored based on excel/sheets formatting * sample file download and small fixes * small changes * removed unnecessary role null check since already in error checker
…o add-tec-to-homepage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Put TEC tracker as a card on homepage.